Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CV UI - E2E Testing for regular and Composite CVs #16238

Merged
merged 8 commits into from
Oct 18, 2024
Merged

CV UI - E2E Testing for regular and Composite CVs #16238

merged 8 commits into from
Oct 18, 2024

Conversation

sambible
Copy link
Contributor

@sambible sambible commented Sep 6, 2024

Adds 2 tests, converted from the old CV UI tests, and updated for modern behavior. E2E testing for Composite and Component CV workflows.

Requires: SatelliteQE/airgun#939

@sambible sambible added AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing 6.16.z Introduced in or relating directly to Satellite 6.16 labels Sep 6, 2024
@sambible sambible self-assigned this Sep 6, 2024
@sambible sambible requested a review from a team as a code owner September 6, 2024 04:25
@sambible sambible mentioned this pull request Sep 6, 2024
Merged
@sambible sambible added the CherryPick PR needs CherryPick to previous branches label Sep 6, 2024
@sambible
Copy link
Contributor Author

sambible commented Sep 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_end_to_end
tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

vsedmik
vsedmik requested changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@vsedmik vsedmik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few proposals and questions pending in my mind.

tests/foreman/ui/test_contentview.py Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
@sambible
Copy link
Contributor Author

sambible commented Sep 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_end_to_end
pytest: tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8512
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 723.12s (0:12:03) ==================

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Sep 6, 2024
@sambible
Copy link
Contributor Author

sambible commented Sep 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8514
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 712.50s (0:11:52) ==================

@sambible
Copy link
Contributor Author

sambible commented Sep 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8515
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 742.75s (0:12:22) ==================

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8516
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 702.64s (0:11:42) ==================

@sambible
Copy link
Contributor Author

sambible commented Sep 6, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8518
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 697.94s (0:11:37) ==================

@sambible
Copy link
Contributor Author

sambible commented Sep 9, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8538
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 747.05s (0:12:27) ==================

@sambible
Copy link
Contributor Author

sambible commented Sep 9, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8539
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 773.28s (0:12:53) ==================

@sambible
Copy link
Contributor Author

sambible commented Sep 9, 2024

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8540
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_ccv_e2e --external-logging
Test Result : ================== 1 failed, 11 warnings in 740.08s (0:12:20) ==================

vijaysawant
vijaysawant requested changes Sep 11, 2024
View reviewed changes
tests/foreman/ui/test_contentview.py Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
tests/foreman/ui/test_contentview.py Outdated Show resolved Hide resolved
@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_end_to_end
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8993
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_end_to_end --external-logging
Test Result : ================= 1 failed, 15 warnings in 1204.10s (0:20:04) ==================

@sambible
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/ui/test_contentview.py::test_positive_end_to_end
airgun: 939

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8999
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/ui/test_contentview.py::test_positive_end_to_end --external-logging
Test Result : ================== 1 passed, 17 warnings in 998.63s (0:16:38) ==================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Oct 17, 2024
@LadislavVasina1 LadislavVasina1 dismissed their stale review October 17, 2024 15:21

I missed some stuff, sry

@LadislavVasina1
Copy link
Contributor

@sambible Could you please address vijays and vladimir's comments that are marked as resolved, but I don't see them in the committed files, thanks.

@Satellite-QE Satellite-QE mentioned this pull request Oct 17, 2024
Merged
@Satellite-QE Satellite-QE removed the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 17, 2024
@sambible sambible requested a review from a team October 18, 2024 14:09
@ColeHiggins2 ColeHiggins2 merged commit bdbe401 into SatelliteQE:master Oct 18, 2024
8 checks passed
github-actions bot pushed a commit that referenced this pull request Oct 18, 2024
@sambible @web-flow
CV UI - E2E Testing for regular and Composite CVs (#16238)
6013cd8 
* Add e2e test for regular and component CV

* Apply suggestions from code review

Co-authored-by: vsedmik <[email protected]>

* Change test comment to match assertion

* Update ccv test docstring

* Small syntax fix

---------

Co-authored-by: vsedmik <[email protected]>
(cherry picked from commit bdbe401)
@Satellite-QE Satellite-QE mentioned this pull request Oct 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysawant vijaysawant vijaysawant requested changes

@LadislavVasina1 LadislavVasina1 LadislavVasina1 approved these changes

@vsedmik vsedmik vsedmik approved these changes

@ColeHiggins2 ColeHiggins2 ColeHiggins2 approved these changes

@chris1984 chris1984 chris1984 approved these changes

Assignees

@sambible sambible

Labels
6.16.z Introduced in or relating directly to Satellite 6.16 AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@sambible @Satellite-QE @LadislavVasina1 @chris1984 @ColeHiggins2 @vijaysawant @vsedmik